kubernetes-sigs / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
298 stars 65 forks source link

🐛 fix pod kube-api-access sa not found #352

Closed yoonmac closed 11 months ago

yoonmac commented 1 year ago

What this PR does / why we need it: Currently, #348 PodKubeAPIAccessMutatorPlugin not works and will get "error looking up serviceAccount ...." error, this PR will fix this issue

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

linux-foundation-easycla[bot] commented 1 year ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yoonmac Once this PR has been reviewed and has the lgtm label, please assign fei-guo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 year ago

Welcome @yoonmac!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-nested 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-nested has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 year ago

Hi @yoonmac. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
yoonmac commented 1 year ago

Hi @christopherhein could you please take a look at this pr? Thanks

Fei-Guo commented 1 year ago

@wondywang , please take a look.

christopherhein commented 1 year ago

@yoonmac can you make sure you sign the CLA too?

/ok-to-test

yoonmac commented 1 year ago

@yoonmac can you make sure you sign the CLA too?

/ok-to-test

@christopherhein I have signed the CLA, now the commit can link to my profile.

yoonmac commented 12 months ago

@wondywang , please take a look. Thanks

wondywang commented 12 months ago

This does seem to be a bug. I implement it internally based on the Admission plugin. Something went wrong with the conversion process. Many thanks to @yoonmac for pointing out this mistakes.

/lgtm

cc @Fei-Guo @christopherhein

yoonmac commented 12 months ago

@yoonmac can you make sure you sign the CLA too? /ok-to-test

@christopherhein I have signed the CLA, now the commit can link to my profile.

@christopherhein could you please help trigger the cla bot? thanks

Fei-Guo commented 11 months ago

/ok-to-test

yoonmac commented 11 months ago

/easycla

yoonmac commented 11 months ago

@Fei-Guo Could you please help approve and merge? I need a new release version based on main. Thanks