search

kubernetes-sigs / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
299 stars 65 forks source link

🌱 Adding new/updated ClusterVersion and VirtualCluster test suites #84

Closed christopherhein closed 3 years ago

christopherhein commented 3 years ago

Now that we've updated to controller-runtime 0.8.3 and were seeing flakes like #79 it made sense to take a second and step back and write tests for at least the native provisioned that some folks have been using and actually get the Reconcilers for both ClusterVersion and VirtualCluster. in doing so this removes the flakes between test suites and cleans up more code.

Related

Closes #79 Related #27 Related #59

Signed-off-by: Chris Hein me@chrishein.com

christopherhein commented 3 years ago

/assign @Fei-Guo

christopherhein commented 3 years ago

/milestone v0.1.x /kind cleanup

christopherhein commented 3 years ago

/kind bug

Fei-Guo commented 3 years ago

Awesome work!

/approve /lgtm

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, Fei-Guo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [Fei-Guo,christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment