kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
275 stars 253 forks source link

Autoscaling to zero #1328

Open mkjpryor opened 1 year ago

mkjpryor commented 1 year ago

/kind feature

Describe the solution you'd like Auto-scaling to and from zero nodes has been implemented upstream - https://github.com/kubernetes/autoscaler/pull/4840.

We should make sure that we implement the provider side of this contract.

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

braghettos commented 1 year ago

Adding a +1 because it would be a great feature!

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

nikParasyr commented 1 year ago

/remove-lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

lukasmrtvy commented 1 year ago

/remove-lifecycle stale

mdbooth commented 1 year ago

https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20210310-opt-in-autoscaling-from-zero.md

nikParasyr commented 1 year ago

IIRC autoscaling from 0 already works, but it requires extra labels/annotations for the cluster-autoscaler. Implementing this would remove the need for these extra labels/annotations so it would be a bit easier for the user.

For me, this wouldnt be very high prio

mkjpryor commented 1 year ago

IIRC autoscaling from 0 already works, but it requires extra labels/annotations for the cluster-autoscaler. Implementing this would remove the need for these extra labels/annotations so it would be a bit easier for the user.

For me, this wouldnt be very high prio

This is correct I think. However I don't really want to have to query the flavor and add custom annotations to my machine deployment when a mechanism exists for the infrastructure provider to do this for me. Agree it isn't high, high priority but would certainly be good to implement the support since the hooks already exist in CAPI.

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

nikParasyr commented 5 months ago

/remove-lifecycle stale

mdbooth commented 5 months ago

@nikParasyr @mkjpryor Do either of you want to work on this, btw? Seems like a good feature.

nikParasyr commented 5 months ago

@mdbooth I dont have any time to work on this (unfortunately)

EmilienM commented 5 months ago

/remove-lifecycle stale

mkjpryor commented 4 months ago

@mdbooth We think a customer might be about to ask for this. If they do then we will work on it.

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

EmilienM commented 1 month ago

/remove-lifecycle stale