search

kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
283 stars 253 forks source link

Add KCP remediation test #1523

Open tormath1 opened 1 year ago

tormath1 commented 1 year ago

Previously these remediation tests were almost the same: one for the control plane and one for the MachineDeployment. But now the KCP test is also checking remediation of the very first node that fails to initialize.

They have put some comments in the code for what is needed: https://github.com/kubernetes-sigs/cluster-api/blob/9ad6d519caed6755da688225172d8999be6c7015/test/e2e/kcp_remediations.go#L52-L77 If I understand it correctly we would need the following:

  1. Define wait intervals for wait-cluster, wait-machines, check-machines-stable and wait-machine-provisioned (if they don't already exist) here.
  2. Ensure that the flavor we use have 3 control plane nodes and 0 workers. I think this is already the case.
  3. The control plane must be configured with preKubeadmCommands that queries for a well-known ConfigMap on the management cluster, holding up bootstrap until a signal is passed via the config map. I'm not even sure if this is possible in our CI since it requires the workload cluster to access the management cluster...
  4. The MachineHealthCheck itself that we already have (may need some tweak though, I haven't checked the exact details of it).

Point 3 is the big one. It may be a bit too much to add in this PR. I would be fine with dropping the KCP test for now since it is basically a completely new test after the changes they made. I will anyway investigate if we can add it later when I have time.

Originally posted by @lentzi90 in https://github.com/kubernetes-sigs/cluster-api-provider-openstack/issues/1521#issuecomment-1505129787

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

tormath1 commented 1 year ago

/remove-lifecycle stale

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

lentzi90 commented 7 months ago

/remove-lifecycle stale

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

lentzi90 commented 4 months ago

/remove-lifecycle stale

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

tormath1 commented 1 month ago

/remove-lifecycle stale