search

kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
299 stars 258 forks source link

Identify Volumes (rootVolumes and additional block devices) with Metadata #1693

Open EmilienM opened 1 year ago

EmilienM commented 1 year ago

/kind feature

Describe the solution you'd like

Anything else you would like to add: Context: https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1668#discussion_r1337423351

EmilienM commented 1 year ago

/assign EmilienM

k8s-triage-robot commented 10 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

dulek commented 10 months ago

/remove-lifecycle stale

mdbooth commented 9 months ago

I wonder if we still need this.

We discovered that using kubernetes uid would break this when doing a CAPI pivot from a management to self-hosted cluster, and other related data moves. This was previously our preferred method of achieving this. With it not being possible we don't have a good solution.

Additionally, while cluster names may conflict, machine resources should generally include the machine name, which contains a generated component. This should make name conflicts for machine resources unlikely in practise, even when using clusters with the same name.

lentzi90 commented 9 months ago

Regarding the UID issue, what about using the provider ID instead? Would that work?

mdbooth commented 9 months ago

Regarding the UID issue, what about using the provider ID instead? Would that work?

Unfortunately I don't think it would because it's only available once the server is created, and the resources we're trying to protect (volumes in this case, but also ports) are created before the server.

We could generate our own uuid and store it in the object status, which I think we've discussed before.

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

EmilienM commented 6 months ago

/remove-lifecycle stale

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

EmilienM commented 3 months ago

/remove-lifecycle stale

k8s-triage-robot commented 2 weeks ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

EmilienM commented 2 weeks ago

/remove-lifecycle stale