Closed EmilienM closed 8 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: EmilienM Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Name | Link |
---|---|
Latest commit | 335cc94f96e1c4146b3721b059b58ffd1eb829db |
Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65ce2a9b3ac2ed0008434769 |
Deploy Preview | https://deploy-preview-1879--kubernetes-sigs-cluster-api-openstack.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Is this just because of the tilt configuration?
Is this just because of the tilt configuration?
I have issues with Tilt yes. Also I think it's a bit risky to upgrade Go if our parent projects (CAPI) hasn't, but I'm maybe wrong on good practices here.
If you think it's fine to use latest go here, I'm happy to hack things on my side to get Tilt working. I'm just worried we want a bit fast for this one, and I thought we would follow CAPI.
/hold
If you think it's fine to use latest go here, I'm happy to hack things on my side to get Tilt working. I'm just worried we want a bit fast for this one, and I thought we would follow CAPI.
I'm pretty sure that go module boundaries allow different modules to use different go versions safely. I wonder if the tilt issue can be resolved by bumping the tilt builder image in https://github.com/kubernetes-sigs/cluster-api/blob/main/Tiltfile.
Tilt is an important workflow so I'm happy to be pragmatic here if staying in lockstep with CAPI is the simplest solution, but it's inevitably going to bite us from time to time so it's worth looking into fixing it directly if possible.
Reverts kubernetes-sigs/cluster-api-provider-openstack#1877
We need to wait for CAPI & controller-runtime being bumped first.