kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
285 stars 252 forks source link

🌱 Fix doc references to NodeCIDR in v1alpha8 #1889

Closed mdbooth closed 7 months ago

mdbooth commented 7 months ago

Fixes: #1887

/hold

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 7 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 4eec0e7b5a2b37424ab4320122e54f3d04a1ebca
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65d34fda5344b80008bad9ce
Deploy Preview https://deploy-preview-1889--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdbooth commented 7 months ago

@MaysaMacedo Please can you take a look at this, particularly the new doctext for Subnets?

dulek commented 7 months ago

/lgtm

jichenjc commented 7 months ago

/test pull-cluster-api-provider-openstack-test

EmilienM commented 7 months ago

/lgtm /hold cancel

pierreprinetti commented 6 months ago

Thank you @mdbooth !