kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
285 stars 252 forks source link

✨ Move `spec.allowAllInClusterTraffic` to `spec.ManagedSecurityGroups` #1892

Closed EmilienM closed 6 months ago

EmilienM commented 7 months ago

What this PR does / why we need it:

Move OpenStackCluster.Spec.AllowAllInClusterTraffic under OpenStackCluster.Spec.ManagedSecurityGroups.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1878

TODOs:

netlify[bot] commented 7 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 350b7e60ca116e8349035a65a263d4cddab651eb
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65d620b09687bc00083160ff
Deploy Preview https://deploy-preview-1892--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

EmilienM commented 6 months ago

We need https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1826 to merge first.

huxcrux commented 6 months ago

/lgtm

huxcrux commented 6 months ago

/lgtm

EmilienM commented 6 months ago

/hold cancel

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
huxcrux commented 6 months ago

/lgtm