kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
283 stars 253 forks source link

Add emilienm to CAPO reviewers #1898

Closed EmilienM closed 6 months ago

netlify[bot] commented 6 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit c1e0f508e792a65caa8c7ccd7175ea6d0f465eb3
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65d60f823679520008e94aa0
Deploy Preview https://deploy-preview-1898--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jichenjc commented 6 months ago

/approve

thanks for the great help here :)

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [jichenjc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mdbooth commented 6 months ago

Please can you change myself to EmilienM in both the PR and the commit message?

mdbooth commented 6 months ago

/lgtm

EmilienM commented 6 months ago

/test pull-cluster-api-provider-openstack-build pull-cluster-api-provider-openstack-test

mdbooth commented 6 months ago

/test pull-cluster-api-provider-openstack-test

mdbooth commented 6 months ago

Looks like https://kubernetes.slack.com/archives/CCK68P2Q2/p1708527057849979

EmilienM commented 6 months ago

/retest