kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
283 stars 253 forks source link

🐛 api/additionalPorts: don't create UDP rules #1899

Closed EmilienM closed 6 months ago

EmilienM commented 6 months ago

What this PR does / why we need it:

When providing additional ports to open on the control plane security group, we'll only open TCP from now as it was initially documented.

Opening UDP by default might not be desired for security reasons.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1704

/hold

netlify[bot] commented 6 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit a5590170a673ea53a91e435158f667e0fce8f9ee
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65d612bfa3af7d00082161c7
Deploy Preview https://deploy-preview-1899--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

EmilienM commented 6 months ago

/retest

dulek commented 6 months ago

/lgtm

mdbooth commented 6 months ago

/approve

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
EmilienM commented 6 months ago

/hold cancel

jichenjc commented 6 months ago

maybe we should consider add a release notes about this as we changed previous behavior