search

kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
283 stars 253 forks source link

🌱 Deprecate v1alpha6 #1900

Closed EmilienM closed 6 months ago

EmilienM commented 6 months ago

What this PR does / why we need it:

Mark v1alpha6 version deprecated in our Kubernetes CRDs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1886

netlify[bot] commented 6 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 05537fb5cb3a9be2315b220ec4ae0fc6075752ff
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65d649671c51330008313eef
Deploy Preview https://deploy-preview-1900--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

huxcrux commented 6 months ago

I have no experience with how deprications have worked prior in CAPO however would it be beneficial to add information regarding deprecation and maybe a removal timeframe to docs or maybe even README?

Away from the above questions I think this pr looks good :)

lentzi90 commented 6 months ago

I have no experience with how deprications have worked prior in CAPO however would it be beneficial to add information regarding deprecation and maybe a removal timeframe to docs or maybe even README?

Away from the above questions I think this pr looks good :)

Yes we should define a policy for how long we support older API versions and releases. I think we could basically copy CAPIs policy.

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [lentzi90] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mdbooth commented 6 months ago

/lgtm