Closed mdbooth closed 6 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mdbooth
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Name | Link |
---|---|
Latest commit | 268645a3bee5e88344c78c6965db8f7b099773b9 |
Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65df360be884290007dcb666 |
Deploy Preview | https://deploy-preview-1905--kubernetes-sigs-cluster-api-openstack.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/test pull-cluster-api-provider-openstack-e2e-test while I'm reviewing it, so see if the e2e issue was transient.
@mdbooth I've added little tests to it, but I think we need to:
controllers/openstackcluster_controller.go
into multiple files handling resources in different files and one file for the higher level loops. We shouldn't do that in this PR and I volunteer to do it when I'm back. I've tracked this in https://github.com/kubernetes-sigs/cluster-api-provider-openstack/issues/1907.Lazily hoping that was a flake without checking:
/test pull-cluster-api-provider-openstack-e2e-test
Testing if our jobs now work in the community prow cluster /test pull-cluster-api-provider-openstack-e2e-test
Update: Looks like it is working :tada: Sorry for the noice. (It does not matter if this test fails, I just wanted to make sure we could get the devstack up)
Looks like something related to floating IPs is borked because we run out. Perhaps they're not being deleted, or created in a loop. It's hard to tell, though, because of https://github.com/kubernetes-sigs/cluster-api-provider-openstack/issues/1840
I think I found the problem from code inspection, although this PR also currently includes #1913 for improved logging just in case. The issue was that we were re-executing floating IP creation on every cluster reconcile when not using an Octavia loadbalancer.
Yay! Looks like that fixed it.
/hold cancel
/lgtm
This change refactors reconcileNetworkComponents into several smaller logical functions which are easier to read and reason about.
It also makes the gocyclo linter happy when making new changes to this code.
/hold