search

kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
283 stars 253 forks source link

Transform neutron filter tags into lists #1909

Closed EmilienM closed 6 months ago

EmilienM commented 6 months ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

/hold

k8s-ci-robot commented 6 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

netlify[bot] commented 6 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 7927f657fe9c2633babfafbcf6dffa6a7d07728a
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65e0e991e614810008e6e095
Deploy Preview https://deploy-preview-1909--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

EmilienM commented 6 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

EmilienM commented 6 months ago

I would have hold cancel if the upgrade patch passed but it failed and I provided a fix here: https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1916 Once this merge, please rebase and run the upgrade job again and if green I think this is good to go.

lentzi90 commented 6 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [lentzi90] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
huxcrux commented 6 months ago

/lgtm

EmilienM commented 6 months ago

/hold cancel