search

kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
283 stars 253 forks source link

Ports follow-up #1910

Closed EmilienM closed 4 months ago

EmilienM commented 6 months ago

What this PR does / why we need it:

A follow-up from @mdbooth & @lentzi90's comments on https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1788.

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EmilienM Once this PR has been reviewed and has the lgtm label, please assign cecilerobertmichon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 6 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 9d31afd842a620d1b8460c5d502867aa427216a9
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65e09bf7ba9f310008dccf90
Deploy Preview https://deploy-preview-1910--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

EmilienM commented 6 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

EmilienM commented 6 months ago 
read: connection reset by peer

/test pull-cluster-api-provider-openstack-e2e-full-test

EmilienM commented 6 months ago

This doesn't work yet.

/hold

k8s-ci-robot commented 6 months ago

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-e2e-full-test 0f41913fb44cf37adcc0e13089720d7a989d1cbb link false /test pull-cluster-api-provider-openstack-e2e-full-test
pull-cluster-api-provider-openstack-e2e-test 9d31afd842a620d1b8460c5d502867aa427216a9 link true /test pull-cluster-api-provider-openstack-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 6 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
EmilienM commented 5 months ago

@mdbooth I guess I should close this one right?

mdbooth commented 4 months ago

The goals of this PR have been various addressed by other v1beta1 PRs.