netlify[bot]
commented
6 months ago Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
| Name | Link |
|---|---|
| Latest commit | 4bb8966639800f145f0539dcaa8738d913ba5ef9 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65de2273d3324e00081b2c9b |
| Deploy Preview | https://deploy-preview-1911--kubernetes-sigs-cluster-api-openstack.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
k8s-ci-robot
mdbooth
This PR includes 2 commits which each make a single change to how the Makefile does code generation.
The first adds the following 2 separate targets:
These invoke
controller-genandconversion-genrespectively. These were previously invoked by thegenerate-gotarget, but that target is now reduced to simply executinggo generate ./....The
generatetarget continues to invoke all code generation.The advantage of this is the ability to easily run only the generation you need during development.
The second commit changes the behaviour of
generate-conversion-gen. This produces no change in output against the current codebase, but fixes an issue generating an incorrect package internal package name should conversion-gen want to add a dependency between packages. I encountered this when I made a change which caused it to do this, which has not yet landed.