🌱 Move webhooks into pkg/webhooks

[mdbooth]

Moves webhooks from api to pkg/webhooks making only mechanical code changes except for:

• the removal of the defaulting webhooks because they were no-ops
• the addition of a conversion webhook for OpenStackClusterTemplateList because it was missing

The former results in there now being no mutating webhook configured.

/hold

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[netlify[bot]]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	cb09d5fe452bd6c2b24dfa1b10c35b8c65b92164
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65e637e917bdc80008f33a00
😎 Deploy Preview	https://deploy-preview-1920--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mdbooth]

Probably not necessary here, but: /test pull-cluster-api-provider-openstack-e2e-full-test

[mdbooth]

I think we still need to define webhooks for the list types even if they don't implement a validator or defaulter, because they will implicitly register a conversion webhook.

[mdbooth]

/test pull-cluster-api-provider-openstack-e2e-full-test

[mdbooth]

The e2e tests were failing because I had added a conversion webhook for OpenStackClusterTemplateList which was not previously present. I added it because it looked like an accidental omission, but it turns out that:

• It does not implement Convertible for old versions
• This caused the e2e tests to fail because the conversion webhook expects all versions of the Hub type which are registered in the current scheme to be convertible, which they weren't.

This also explains why the API validation tests weren't failing, because they weren't registering old API versions in the test scheme. I've fixed this by:

• Registering the old API versions in the test scheme of the API validations tests
• Fixed the resulting test failure by implementing Convertible where it was missing.

I've left these things as separate commits because they're logically separate changes. However, they are all required for the tests to pass on this PR.

[mdbooth]

/test pull-cluster-api-provider-openstack-e2e-full-test

[mdbooth]

Given that the full test passed, I'm guessing that could have been a flake.

/retest-required

[JoelSpeed]

/lgtm

Big step in the right direction towards decoupling API types from imports, LGTM

[mdbooth]

/hold cancel