🌱 Move filter conversions out of /api

mdbooth commented 6 months ago

Removes a gophercloud dependency for consumers of the API.

This is the complement to https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1920. Together they remove most external dependencies when importing v1beta1, although due to the conversion dependency importing prior versions still also pull in controller-runtime.

/hold

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

netlify[bot] commented 6 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
Latest commit	d33fee8e4789e7a72ad7688602a41810555820eb
Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65e8a3231cb88d0008fc1776
Deploy Preview	https://deploy-preview-1924--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdbooth commented 6 months ago

Have you tested, with this PR in combination with #1920 what happens to a go.mod if you write a simple program that imports one of your v1beta1 types and just prints it out or something simple?

Would be good to see what go.mod that creates

main.go:

package main

import (
        "fmt"

        "sigs.k8s.io/cluster-api-provider-openstack/api/v1beta1"
)

func main() {
        cluster := v1beta1.OpenStackCluster{}
        fmt.Printf("%+v\n", cluster)
}

go.mod:

require sigs.k8s.io/cluster-api-provider-openstack v0.9.0

require (
        github.com/emicklei/go-restful/v3 v3.11.0 // indirect
        github.com/go-logr/logr v1.3.0 // indirect
        github.com/go-openapi/jsonpointer v0.19.6 // indirect
        github.com/go-openapi/jsonreference v0.20.2 // indirect
        github.com/go-openapi/swag v0.22.3 // indirect
        github.com/gogo/protobuf v1.3.2 // indirect
        github.com/golang/protobuf v1.5.3 // indirect
        github.com/google/gnostic-models v0.6.8 // indirect
        github.com/google/go-cmp v0.6.0 // indirect
        github.com/google/gofuzz v1.2.0 // indirect
        github.com/josharian/intern v1.0.0 // indirect
        github.com/json-iterator/go v1.1.12 // indirect
        github.com/mailru/easyjson v0.7.7 // indirect
        github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
        github.com/modern-go/reflect2 v1.0.2 // indirect
        github.com/pkg/errors v0.9.1 // indirect
        golang.org/x/net v0.19.0 // indirect
        golang.org/x/text v0.14.0 // indirect
        google.golang.org/protobuf v1.31.0 // indirect
        gopkg.in/inf.v0 v0.9.1 // indirect
        gopkg.in/yaml.v2 v2.4.0 // indirect
        gopkg.in/yaml.v3 v3.0.1 // indirect
        k8s.io/api v0.28.4 // indirect
        k8s.io/apiextensions-apiserver v0.28.4 // indirect
        k8s.io/apimachinery v0.28.4 // indirect
        k8s.io/klog/v2 v2.100.1 // indirect
        k8s.io/kube-openapi v0.0.0-20230717233707-2695361300d9 // indirect
        k8s.io/utils v0.0.0-20230406110748-d93618cff8a2 // indirect
        sigs.k8s.io/cluster-api v1.6.0 // indirect
        sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect
        sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect
)

mdbooth commented 6 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

k8s-ci-robot commented 6 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

huxcrux commented 6 months ago

/lgtm

EmilienM commented 6 months ago

/hold cancel

kubernetes-sigs / cluster-api-provider-openstack