Closed mdbooth closed 7 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mdbooth
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Name | Link |
---|---|
Latest commit | a81ef96d6da8e0554f563591c932dbc6d48636b3 |
Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65e7315c48d50d0008f41cab |
Deploy Preview | https://deploy-preview-1925--kubernetes-sigs-cluster-api-openstack.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/lgtm
Thanks
/hold cancel
This is a breaking change, although it should not have any negative effects in practise.
The v1alpha6 cluster restorer had become too complex with too many individual fields. This change reduces the number of fields to be consistent with the v1alpha7 restorer.
With this change, an object stored as v1alpha6 with previous v1beta1 annotations could have fields in its spec restored to a semantically equivalent but slightly different serialisation when converted to v1beta1. Differences in the bastion and status are not affected.
In practise this should not matter for 2 reasons:
Note that if the object is not under external control these differences should not matter anyway.
/hold