⚠️ ImageFilter - add exclusive validation -> pointers

[dulek]

What this PR does / why we need it: This commit changes ID and Name of ImageFilter to pointers which should only affect go marshalling.

Other than that it adds CEL validation of the ImageFilter, so that Name or Tags can only be set when ID is unset. Conversions are updated accordingly to make sure we only set Name when ID is unset.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• [X] squashed commits
• if necessary:
  • [X] includes documentation
  • [X] adds unit tests

/hold

[netlify[bot]]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	dc3959e0dd803c30361cbf6697293db6090dad66
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65f2de403df8320009748c6e
😎 Deploy Preview	https://deploy-preview-1939--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[huxcrux]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[dulek]

@mdbooth: I fixed a comment, but I'm still unsure about ImageFilter being optional. Digging into that now.

[EmilienM]

/test pull-cluster-api-provider-openstack-e2e-full-test /lgtm

I think all comments were addressed (nice work!) but I'll let Matt hold cancel.

[dulek]

So we still wanted to add validation that when ID is not set, the filter has at least one other option set. Now I started working on Bastion to fix this, because this means we're unable to create an empty machine, but maybe it's an overkill. Technically an empty filter is still valid if you have just one image.

[dulek]

I added the explicit +required on the ImageFilter. I guess this is good to go, I can expand the filter in the Bastion patch.

[dulek]

/retest

[EmilienM]

/test pull-cluster-api-provider-openstack-e2e-full-test /lgtm

[dulek]

/hold cancel