Closed mdbooth closed 6 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mdbooth
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Name | Link |
---|---|
Latest commit | c4e5c2a99503874e160154e091cf712788213566 |
Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65f9bd5f12e23900085875bb |
Deploy Preview | https://deploy-preview-1957--kubernetes-sigs-cluster-api-openstack.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/test pull-cluster-api-provider-openstack-e2e-test
This looks good, skipping /lgtm
to allow the full e2e test to run.
This should have had
/hold
This is a bug in this patch:
failureMessage: 'failed to reconcile security groups: unable to generate desired
security group rules: security group k8s-cluster-e2e-bql68j-cluster-e2e-bql68j-secgroup-bastion
not found'
D'oh! That's so dumb: when I was moving the code which generates observedSecGroups
I didn't actually add the created groups to the map 🤦
We have test coverage of the various methods called by ReconcileSecurityGroups
, but none of ReconcileSecurityGroups
itself, so the local tests missed this. I'll see if I can add something which would have caught this.
I've fixed the bug and added some unit tests which would have triggered it.
/test pull-cluster-api-provider-openstack-e2e-full-test
/test pull-cluster-api-provider-openstack-e2e-full-test
/test pull-cluster-api-provider-openstack-e2e-full-test
/lgtm
/hold cancel
We were writing the full set of generated security rules to the status. They dominated the size of cluster object and we weren't reading them: we always fetch the current rules from OpenStack during reconciliation.
This also tweaks the rule generation code slightly, which was previously reading security group rules multiple times during a reconciliation. We now do this first and pass the result around.
Fixes: #1956