kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
289 stars 253 forks source link

🐛 Add terminal failure for lb client init #1960

Closed Goend closed 5 months ago

Goend commented 6 months ago

What this PR does / why we need it: After loadBalancerService client init failed,we should give failed message to openstackcluster status.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1950

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

/hold

k8s-ci-robot commented 6 months ago

Welcome @Goend!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 6 months ago

Hi @Goend. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 6 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 5d69a0fd00511bca1a521d6599722ef3fad0821a
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/661e430fc56d4d00080b0f20
Deploy Preview https://deploy-preview-1960--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

huxcrux commented 6 months ago

/ok-to-test

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign cecilerobertmichon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 5 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
EmilienM commented 5 months ago

@Goend if you like, I can help you with this PR. Let me know and I can push your patch via another PR with everything fixed.

Goend commented 5 months ago

OK, I am not able to handle everything skillfully, which has wasted a lot of time. Now you can push my patch via another PR with everything fixed.Thanks


From: Emilien Macchi @.> Sent: Tuesday, April 23, 2024 10:53:43 PM To: kubernetes-sigs/cluster-api-provider-openstack @.> Cc: Goend @.>; Mention @.> Subject: Re: [kubernetes-sigs/cluster-api-provider-openstack] 🐛 Add terminal failure for lb client init (PR #1960)

@Goendhttps://github.com/Goend if you like, I can help you with this PR. Let me know and I can push your patch via another PR with everything fixed.

— Reply to this email directly, view it on GitHubhttps://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1960#issuecomment-2072568313, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJUF4YZJXOHMYMCQKXBFYHDY6ZYXPAVCNFSM6AAAAABE64KQJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZSGU3DQMZRGM. You are receiving this because you were mentioned.Message ID: @.***>

EmilienM commented 5 months ago

/close This was moved to https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2036

k8s-ci-robot commented 5 months ago

@EmilienM: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1960#issuecomment-2075081374): >/close >This was moved to https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2036 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.