⚠️ Remove InstanceID from machine spec

mdbooth commented 4 months ago

This is a status field and should not be included in the spec. ProviderID is the same, but cannot be removed as it is required by Cluster API.

While we're changing it, we change the default printcolumns for OpenStackMachine to report server ID instead of provider ID. We don't need to report provider ID here because we already know everything is an openstack server. New output example:

> kc get openstackmachine
NAME             CLUSTER    SERVERID                               INSTANCESTATE   READY   MACHINE          AGE
test-foo-fbvcg   test-foo   b4547d60-0f7e-44ea-b77a-30e951556fe3   ACTIVE          true    test-foo-fbvcg   5m52s

/hold

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

netlify[bot] commented 4 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
Latest commit	a3c6d591183fb755fb27cfcb0fe0c939463b6adc
Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6606e14fd08a6500089cc8c9
Deploy Preview	https://deploy-preview-1961--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdbooth commented 4 months ago

This needs a docs update, and also an update to the machine printcolumns.

mdbooth commented 4 months ago

Should be good to go now.

mdbooth commented 4 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

mdbooth commented 4 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

mdbooth commented 4 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

MaysaMacedo commented 4 months ago

/lgtm

k8s-ci-robot commented 4 months ago

New changes are detected. LGTM label has been removed.

dulek commented 3 months ago

Okay, I think I found the issue.

k8s-ci-robot commented 3 months ago

@mdbooth: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-openstack-e2e-test	a3c6d591183fb755fb27cfcb0fe0c939463b6adc	link	true	`/test pull-cluster-api-provider-openstack-e2e-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

k8s-ci-robot commented 3 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

mdbooth commented 3 months ago

I've decided to replace this with https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1988, which has a smaller scope.

kubernetes-sigs / cluster-api-provider-openstack