kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
279 stars 252 forks source link

🌱 Update FloatingIPPool to use v1beta1 #1962

Closed mdbooth closed 4 months ago

mdbooth commented 4 months ago

Also make IdentityRef required, as it doesn't currently permit fallback to cluster credentials.

cc @bilbobrovall @huxcrux

/hold

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 4 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 24b7961f9227a9b7d6ff9914a3e8aa684c906c06
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65fadfd65073a500088e9656
Deploy Preview https://deploy-preview-1962--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdbooth commented 4 months ago

size/L. I'm guessing that means either it didn't work, or the .gitattributes change isn't applied to this PR. The non-generated diffstat is actually:

api/v1alpha1/openstackfloatingippool_types.go     | 18 +++++-------------
controllers/openstackfloatingippool_controller.go |  7 +++----
pkg/scope/provider.go                             | 12 +++---------
3 files changed, 11 insertions(+), 26 deletions(-)
mdbooth commented 4 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

huxcrux commented 4 months ago

/lgtm

dulek commented 4 months ago

/lgtm

mdbooth commented 4 months ago

/hold cancel