Closed mdbooth closed 4 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mdbooth
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Name | Link |
---|---|
Latest commit | 24b7961f9227a9b7d6ff9914a3e8aa684c906c06 |
Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65fadfd65073a500088e9656 |
Deploy Preview | https://deploy-preview-1962--kubernetes-sigs-cluster-api-openstack.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
size/L
. I'm guessing that means either it didn't work, or the .gitattributes change isn't applied to this PR. The non-generated diffstat is actually:
api/v1alpha1/openstackfloatingippool_types.go | 18 +++++-------------
controllers/openstackfloatingippool_controller.go | 7 +++----
pkg/scope/provider.go | 12 +++---------
3 files changed, 11 insertions(+), 26 deletions(-)
/test pull-cluster-api-provider-openstack-e2e-full-test
/lgtm
/lgtm
/hold cancel
Also make IdentityRef required, as it doesn't currently permit fallback to cluster credentials.
cc @bilbobrovall @huxcrux
/hold