kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
279 stars 252 forks source link

🌱 Add .gitattributes to identify generated files to GitHub #1963

Closed mdbooth closed 4 months ago

mdbooth commented 4 months ago

Example: https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github

A primary is to stop labelling relatively small commits as XXL just because they update some doctext which is referenced in several places in the CRDs.

This does what I intend in git:

> git check-attr linguist-generated ./config/crd/bases/infrastructure.cluster.x-k8s.io_openstackclusters.yaml ./config/crd/kustomization.yaml
./config/crd/bases/infrastructure.cluster.x-k8s.io_openstackclusters.yaml: linguist-generated: true
./config/crd/kustomization.yaml: linguist-generated: unspecified

However, I'm far from convinced the github integration is working. I originally included it in https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1962, but it still seemed to be mislabelled.

/hold

netlify[bot] commented 4 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 4cd4e9ff98195f622e9bddd91df450ddc2523e71
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65fae485c7e051000762c7c6
Deploy Preview https://deploy-preview-1963--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mdbooth commented 4 months ago

CAPI are using the same attribute: https://github.com/kubernetes-sigs/cluster-api/blob/main/.gitattributes

huxcrux commented 4 months ago

/lgtm

dulek commented 4 months ago

Nice!

mdbooth commented 4 months ago

/hold cancel