kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
289 stars 253 forks source link

🌱 Rename referencedResources and dependentResources #1965

Closed mdbooth closed 6 months ago

mdbooth commented 6 months ago

This is just a rename. It contains no functional code changes.

referencedResources becomes resolved. It is a set of fully resolved intents based on the spec and the environment.

dependentResources becomes resources because it's a collection of OpenStack resources, and dependent was redundant.

TODO:

/hold

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 6 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 5d11950182257ee750db3c84534ba4621b100544
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65fd8244db97980007373286
Deploy Preview https://deploy-preview-1965--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jichenjc commented 6 months ago

/lgtm

mdbooth commented 6 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

dulek commented 6 months ago

/lgtm

mdbooth commented 6 months ago

/hold cancel