kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
289 stars 253 forks source link

🐛 Revert accidental update to previous API templates #1966

Closed mdbooth closed 6 months ago

mdbooth commented 6 months ago

https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1959 accidentally updated the bastion spec for the v1alpha6 and v1alpha7 tests, which breaks the upgrade test.

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 6 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 61b056060e869d8a43e767d386aa79cbd6716393
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65fc61a45b6f3100085846b5
Deploy Preview https://deploy-preview-1966--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdbooth commented 6 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

dulek commented 6 months ago

/lgtm

My bad, thank you Matt!

mdbooth commented 6 months ago

Until we've seen the upgrade test pass.

/hold

mdbooth commented 6 months ago

/hold cancel