kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
279 stars 252 forks source link

⚠️ Resolved and Resources become optional pointer types #1967

Closed mdbooth closed 4 months ago

mdbooth commented 4 months ago

This updates Resolved and Resources in both OpenStackMachine and the Bastion to be optional pointer types.

TODO:

/hold

netlify[bot] commented 4 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 2758a6d27d46202ff8cff16374de8a2cc728993a
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/660183f0aceb4d0008935242
Deploy Preview https://deploy-preview-1967--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdbooth commented 4 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

mdbooth commented 4 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

dulek commented 4 months ago

/lgtm

jichenjc commented 4 months ago

/approve /hold cancel

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [jichenjc,mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment