search

kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
289 stars 253 forks source link

Add an opt to use AZ for APISeverLoadBalancer #1969

Closed nguyenhuukhoi closed 6 months ago

nguyenhuukhoi commented 6 months ago

What this PR does / why we need it: This PR allows to choose AZ for API Load Balancer. It will be useful if we want to use edge sites,

Which issue(s) this PR fixes (optional, in fixes #(, fixes #, ...) format, will close the issue(s) when PR gets merged):

/hold

linux-foundation-easycla[bot] commented 6 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nguyenhuukhoi Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 6 months ago

Welcome @nguyenhuukhoi!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 6 months ago

Hi @nguyenhuukhoi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 6 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit c9acc4fa66ef5611a3df32e200643528b35fb04e
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6604be943246d00008bb0b4e
Deploy Preview https://deploy-preview-1969--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nguyenhuukhoi commented 6 months ago

Thanks for your PR, this is a good addition to CAPO 👍

We probably do not want this in older APIs (non v1beta1) however I let one of the approvers make a decision on this. Generally new features is not backported to older API versions unless a bug is found.

When you feel like you are done with this PR it would be nice if you squash your commits to keep the main branch tidy.

/ok-to-test Hello. We dont add new features on older APIs, Does it is our rule?

nguyenhuukhoi commented 6 months ago

/retest

nguyenhuukhoi commented 6 months ago

Hello. Is it ok if I drop Convert_v1beta1_APIServerLoadBalancer_To_v1alpha7_APIServerLoadBalancer?

nguyenhuukhoi commented 6 months ago

/retest

nguyenhuukhoi commented 6 months ago

When you feel like you are done with this PR it would be nice if you squash your commits to keep the main branch tidy.

Hello. Could u explain it?

dulek commented 6 months ago

When you feel like you are done with this PR it would be nice if you squash your commits to keep the main branch tidy.

Hello. Could u explain it?

We mean that commits should be squashed into one or at most a few logical parts that can be independently reverted. I'm pretty sure this can land as a single commit.

git rebase -i <first-commit> will help you do this.

nguyenhuukhoi commented 6 months ago

git rebase -i Hello. Could you explain more detail on that?

nguyenhuukhoi commented 6 months ago

/retest

k8s-ci-robot commented 6 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 6 months ago

@nguyenhuukhoi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-e2e-test c9acc4fa66ef5611a3df32e200643528b35fb04e link true /test pull-cluster-api-provider-openstack-e2e-test
pull-cluster-api-provider-openstack-build c9acc4fa66ef5611a3df32e200643528b35fb04e link true /test pull-cluster-api-provider-openstack-build
pull-cluster-api-provider-openstack-test c9acc4fa66ef5611a3df32e200643528b35fb04e link true /test pull-cluster-api-provider-openstack-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).