search

kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
279 stars 252 forks source link

⚠️ Split ImageFilter into ImageParam #1970

Closed mdbooth closed 3 months ago

mdbooth commented 4 months ago

See https://github.com/kubernetes-sigs/cluster-api-provider-openstack/issues/1975

TODO:

/hold

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 4 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 44be48e4f9e20eb7b31eaadb5612dcf80e9fd84c
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6606c14776200c000841e2b7
Deploy Preview https://deploy-preview-1970--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdbooth commented 4 months ago

/test pull-cluster-api-provider-openstack-test

mdbooth commented 4 months ago

I don't immediately understand this failure. AFAICT the generated files are up to date.

mdbooth commented 3 months ago

It's failing to load an OpenStackMachineTemplate which contains an invalid imageparam. However, looking at the generated templated artifacts I can't see it. I don't currently know where the invalid data is coming from.

mdbooth commented 3 months ago

It's failing to load an OpenStackMachineTemplate which contains an invalid imageparam. However, looking at the generated templated artifacts I can't see it. I don't currently know where the invalid data is coming from.

Found it: I'd missed where the flatcar templates patch the image separately.

mdbooth commented 3 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

mdbooth commented 3 months ago

/test pull-cluster-api-provider-openstack-test /test pull-cluster-api-provider-openstack-e2e-full-test

mdbooth commented 3 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

dulek commented 3 months ago

/lgtm

dulek commented 3 months ago

@mdbooth: Does this need a rebase or can I just unhold this?

mdbooth commented 3 months ago

As long as the previous one merged, just unhold it.

dulek commented 3 months ago

/hold cancel