kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
289 stars 253 forks source link

⚠️SecurityGroupFilter to SecurityGroupParam #1974

Closed mdbooth closed 6 months ago

mdbooth commented 6 months ago

See https://github.com/kubernetes-sigs/cluster-api-provider-openstack/issues/1975

TODO:

/hold

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 6 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 865933dc4087ba80a49a3f289f2396c9d93ec2bf
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6606c1106f97ea0008e70b6a
Deploy Preview https://deploy-preview-1974--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdbooth commented 6 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

mdbooth commented 6 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

mdbooth commented 6 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

mdbooth commented 6 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

mdbooth commented 6 months ago

Last push simply removes the commented code.

dulek commented 6 months ago

/lgtm

mdbooth commented 6 months ago

/hold cancel

I'd re-run the full test, but as I literally only removed some commented-out-code since it last ran successfully on this PR I won't. (- Words on my tombstone)