search

kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
289 stars 253 forks source link

⚠️ RouterFilter to RouterParam #1978

Closed mdbooth closed 6 months ago

mdbooth commented 6 months ago

See https://github.com/kubernetes-sigs/cluster-api-provider-openstack/issues/1975

An earlier version of this PR broke router deletion. It seems we have no unit test coverage of router reconciliation, so this PR also adds a test suite which would have caught the bug.

TODO:

/hold

netlify[bot] commented 6 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 5c3fe97e7542dc5c5c52d9a0b7f48d2168ead1fc
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6606c159fb901600082160b2
Deploy Preview https://deploy-preview-1978--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdbooth commented 6 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

mdbooth commented 6 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mdbooth commented 6 months ago

/hold cancel