Closed nguyenhuukhoi closed 3 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nguyenhuukhoi Once this PR has been reviewed and has the lgtm label, please assign jichenjc for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @nguyenhuukhoi. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
@nguyenhuukhoi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
Name | Link |
---|---|
Latest commit | 2cb079c2558915abd5107b10f5cd745346891165 |
Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/660c9c396d05f20008d6ab7a |
Deploy Preview | https://deploy-preview-1979--kubernetes-sigs-cluster-api-openstack.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/ok-to-test
I took the freedom to try to fix this patch, please check out: https://github.com/nguyenhuukhoi/cluster-api-provider-openstack/pull/1
Hello. Thank you for your help. I am busy on this week. I will continue next week.
On Tue, Apr 2, 2024, 10:37 PM Michal Dulko @.***> wrote:
I took the freedom to try to fix this patch, please check out: nguyenhuukhoi#1 https://github.com/nguyenhuukhoi/cluster-api-provider-openstack/pull/1
— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1979#issuecomment-2032401673, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRLKQO2VFMJQPT27N4YIEDY3LGDDAVCNFSM6AAAAABFMF6VVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZSGQYDCNRXGM . You are receiving this because you were mentioned.Message ID: <kubernetes-sigs/cluster-api-provider-openstack/pull/1979/c2032401673@ github.com>
/retest
I took the freedom to try to fix this patch, please check out: nguyenhuukhoi#1
Hello. I do a mistake. Could you help me revert it?
PR needs rebase.
@nguyenhuukhoi: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
pull-cluster-api-provider-openstack-build | 2cb079c2558915abd5107b10f5cd745346891165 | link | true | /test pull-cluster-api-provider-openstack-build |
pull-cluster-api-provider-openstack-test | 2cb079c2558915abd5107b10f5cd745346891165 | link | true | /test pull-cluster-api-provider-openstack-test |
pull-cluster-api-provider-openstack-e2e-test | 2cb079c2558915abd5107b10f5cd745346891165 | link | true | /test pull-cluster-api-provider-openstack-e2e-test |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
I submitted a new PR where I rebased this: #2004.
As noted, this commit has been rebased into PR #2004
What this PR does / why we need it: We need this option to use in case of having edge
This PR allows to choose AZ for API Load Balancer. It will be useful if we want to use edge sites,
/ok-to-test