search

kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
279 stars 252 forks source link

📖 Document changes to Filters #1982

Closed mdbooth closed 3 months ago

mdbooth commented 3 months ago

Requires:

Fixes: https://github.com/kubernetes-sigs/cluster-api-provider-openstack/issues/1975

/hold

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 3 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 2901efed3daf7637fd9cf0a4bf508e17da4329e3
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/660bd63c6cf34f00082969d1
Deploy Preview https://deploy-preview-1982--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot commented 3 months ago

@mdbooth: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-e2e-test 9cab28d3ac0204f7bae2d0208af4b3be95f03745 link true /test pull-cluster-api-provider-openstack-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
huxcrux commented 3 months ago

/lgtm

mdbooth commented 3 months ago

/hold cancel

mdbooth commented 3 months ago

/hold

Bah. Forgot I needed to address nits.

mdbooth commented 3 months ago

/hold cancel

mdbooth commented 3 months ago

/hold for comments and to add ServerGroupParam

mdbooth commented 3 months ago

Updated to reference the filter changes specificially under Images, ExternalNetwork, and Network. Additionally added ServerGroupParam, although that hasn't actually landed yet. It's in https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1991

dulek commented 3 months ago

/lgtm

dulek commented 3 months ago

Let's unhold once #1991 is in.

mdbooth commented 3 months ago

/hold cancel