Closed mdbooth closed 6 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mdbooth
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Name | Link |
---|---|
Latest commit | 5c1ad44dbb0de3ed6aff740a844b7ee1e511a161 |
Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/660ad176a95ee60008ecace4 |
Deploy Preview | https://deploy-preview-1988--kubernetes-sigs-cluster-api-openstack.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/test pull-cluster-api-provider-openstack-e2e-full-test
/lgtm
looks good
/hold cancel
This is a status field and should not be included in the spec. ProviderID is the same, but cannot be removed as it is required by Cluster API.
This PR replaces https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1961 with a smaller scope.
TODO:
restorev1alpha6MachineTemplateMachineSpec
into https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1989/hold