search

kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
275 stars 253 forks source link

⚠️ ServerGroupFilter to ServerGroupParam #1991

Closed mdbooth closed 3 months ago

mdbooth commented 3 months ago

See https://github.com/kubernetes-sigs/cluster-api-provider-openstack/issues/1975

/hold

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 3 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 8ea3ccf6d45ebf64e4e18db5002c85e72bcf6fae
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/660bcf3d9b77c90008656de8
Deploy Preview https://deploy-preview-1991--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdbooth commented 3 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

mdbooth commented 3 months ago

Lets wait for the full test as it's an API change.

mdbooth commented 3 months ago

/hold cancel