search

kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
275 stars 253 forks source link

🌱 Remove legacy v1alpha7 filterconvert utils #1992

Closed mdbooth closed 3 months ago

mdbooth commented 3 months ago

This should have been removed with https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1962 but I missed it.

/hold

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 3 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 7c0d7410ddbf5e61b627efec133486e09bc5bc40
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/660bf93fc16c6000081c30d0
Deploy Preview https://deploy-preview-1992--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dulek commented 3 months ago

/lgtm

mdbooth commented 3 months ago

/hold cancel

mdbooth commented 3 months ago

I wonder if I can still hold this. It would be convenient to merge #1994 first.

/hold

mdbooth commented 3 months ago

/hold cancel