kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
275 stars 253 forks source link

🌱 Bump version artifacts for release-0.10 #1994

Closed mdbooth closed 3 months ago

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 3 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit ed829b35a764ac199a36b9fb720d5033b8dbe28d
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/660c13b96f041e0008944702
Deploy Preview https://deploy-preview-1994--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dulek commented 3 months ago

Looks good, but I wonder why it's needed now and not on 0.10 release.

mdbooth commented 3 months ago

Looks good, but I wonder why it's needed now and not on 0.10 release.

It will be needed on main as soon as a v0.10 tag is created due to the way we generate version numbers and clusterctl gets metadata.

If we tag v0.10 without this it won't be possible to deploy it with clusterctl. As soon as we do tag it, it will also be required on main, so we might as well merge it in main and push to the release branch.

dulek commented 3 months ago

/lgtm

dulek commented 3 months ago

/lgtm