Closed bilbobrovall closed 3 months ago
Hi @bilbobrovall. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Name | Link |
---|---|
Latest commit | df19807006a01aa65a684ae152d922ba8ec09a46 |
Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/660d8203f343f00007704ad3 |
Deploy Preview | https://deploy-preview-1996--kubernetes-sigs-cluster-api-openstack.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/ok-to-test
Makes sense to me, tiny request for clarification in the comments.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mdbooth
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold cancel
What this PR does / why we need it: Adds support in
GetPortForExternalNetwork
for more distributed/ha-routersWhich issue(s) this PR fixes: Fixes #1985
I'm not 100% sure if we need all these device_owners or if we need some additional, I got them from https://github.com/openstack/neutron-lib/blob/master/neutron_lib/constants.py#L74 but didn't find any good documentation on them.
Special notes for your reviewer:
TODOs:
/hold