kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
275 stars 253 forks source link

🌱 Cleanup security group created by e2e test #2010

Closed mdbooth closed 2 months ago

mdbooth commented 3 months ago

Discovered by https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2005

TODO:

/hold

netlify[bot] commented 3 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 43d24995c3ddfd0ad8e73b4611faf3119be9dfdc
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6616feff5f18720008f1aacc
Deploy Preview https://deploy-preview-2010--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdbooth commented 3 months ago

Confirmed cleanup in log output https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-openstack/2010/pull-cluster-api-provider-openstack-e2e-test/1778167450840338432/build-log.txt

STEP: Deleting test security group testSecGroup(17e01d8b-e8a5-4479-b367-305d0ac11e9a) @ 04/10/24 21:46:30.648
k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [lentzi90] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
huxcrux commented 2 months ago

/lgtm

mdbooth commented 2 months ago

/hold cancel