kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
275 stars 253 forks source link

v1beta1 does not correctly validate the name of additionalBlockDevices #2013

Open mdbooth opened 2 months ago

mdbooth commented 2 months ago

/kind bug

v1beta1 permits creating an additionalBlockDevice with an empty name, and with the name "root". There may be other issues.

I wrote test cases for these when writing https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2008 but noticed that they were failing. I left the code in, commented out. Assuming that PR merges, we should uncomment those tests and fix them.