search

kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
275 stars 253 forks source link

We don't test clusterctl move #2025

Closed mdbooth closed 2 months ago

mdbooth commented 2 months ago

/kind bug clusterctl move does not copy object status. While we are probably ok with the new state fields in OpenStackMachine (and the bastion) because we considered upgrade where they were not previously set, we should certainly test this.

CAPI's SelfHostedSpec exercises this: https://github.com/kubernetes-sigs/cluster-api/blob/ec900f852f8dc45887a4972632b789176ab6ec08/test/e2e/self_hosted.go#L42

We should implement this as soon as possible.

lentzi90 commented 2 months ago

I'm pretty sure we do test this in the optional suite! I'm after all the one who added it :sweat_smile: https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/test/e2e/suites/e2e/self_hosted_test.go

mdbooth commented 2 months ago

Well that came to a rapid conclusion 😎