search

kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
289 stars 253 forks source link

🐛 Remove cluster dependency to resolve ports #2040

Closed EmilienM closed 3 months ago

EmilienM commented 5 months ago

What this PR does / why we need it:

The default network and some other ports parameters are now figured out outside of the port functions, so they don't rely on the OpenStackMachine spec directly anymore.

/hold

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign mdbooth for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 5 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 3a2ad2915eae3c5dd554651813bbdad57bd0c8e9
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/66325bccb3a5ba0008fbbea2
Deploy Preview https://deploy-preview-2040--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

EmilienM commented 5 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

EmilienM commented 5 months ago

/test pull-cluster-api-provider-openstack-e2e-test

EmilienM commented 5 months ago

/test pull-cluster-api-provider-openstack-e2e-test a flake

k8s-ci-robot commented 5 months ago

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-e2e-full-test 6fb7b8cbd7371ce65b53e93bca903f19ddabab91 link false /test pull-cluster-api-provider-openstack-e2e-full-test
pull-cluster-api-provider-openstack-test 3a2ad2915eae3c5dd554651813bbdad57bd0c8e9 link true /test pull-cluster-api-provider-openstack-test
pull-cluster-api-provider-openstack-e2e-test 3a2ad2915eae3c5dd554651813bbdad57bd0c8e9 link true /test pull-cluster-api-provider-openstack-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 5 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.