kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
289 stars 253 forks source link

:bug:issue-1711: Dependency on deprecated github.com/golang/mock #2048

Closed MykolaRodin closed 5 months ago

MykolaRodin commented 5 months ago

What this PR does / why we need it:

This MR uses uber-go/mock instead of deprecated github.com/golang/mock/gomock

Fixes: #1711

linux-foundation-easycla[bot] commented 5 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 5 months ago

Welcome @MykolaRodin!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 5 months ago

Hi @MykolaRodin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 5 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 21fa8b2c0e189cf36f97ec75e00215b6bcb87edc
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6634b6bb79dd51000976e6a4
Deploy Preview https://deploy-preview-2048--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdbooth commented 5 months ago

/ok-to-test

Thank you! I'll update the description with a Fixes stanza so #1711 is automatically closed when this merges.

mdbooth commented 5 months ago

/approve

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lentzi90 commented 5 months ago

Thanks! May I also ask that you squash the commits to one, please!

MykolaRodin commented 5 months ago

I tried to do it using git rebase -i with subsequent steps and failed. That is why I deleted my last commit (git reset --hard 1c5dc315bb125f92f43778bf1a75b6ad05f72739 and git push --force), made the required modifications in the code and committed them modifying the only remaining commit (git commit --amend and git push --force). That is the best I can do.

lentzi90 commented 5 months ago

It looks fine :slightly_smiling_face:

MykolaRodin commented 5 months ago

Thank you. If it is fine, could you please resolve our conversation above?

lentzi90 commented 5 months ago

I have already done so. This will merge as soon as all the tests have passed. The e2e test takes about 1 h so I estimate that this will be merge in about half an hour. :slightly_smiling_face: