kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
275 stars 253 forks source link

🐛 [release-0.10] Fix enabling of disabled bastion on upgrade to v1beta1 #2053

Closed mdbooth closed 2 months ago

mdbooth commented 2 months ago

This is a manual backport of #2052. An automated backport is not possible due to the removal of v1alpha5 and v1alpha6 tests on main.

TODO:

/hold

netlify[bot] commented 2 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 9082ab0f247293bcd6ebdd8975575bc84303e271
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6634cd01c663fa0007b53eed
Deploy Preview https://deploy-preview-2053--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdbooth commented 2 months ago

/test pull-cluster-api-provider-openstack-e2e-full-test

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/release-0.10/OWNERS)~~ [lentzi90] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
EmilienM commented 2 months ago

/lgtm /hold cancel