search

kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
275 stars 253 forks source link

🐛 Fix empty version output in release builds #2056

Closed mdbooth closed 2 months ago

mdbooth commented 2 months ago

Fixes #2055

mdbooth commented 2 months ago

/cherry-pick release-0.10

k8s-infra-cherrypick-robot commented 2 months ago

@mdbooth: once the present PR merges, I will cherry-pick it on top of release-0.10 in a new PR and assign it to you.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2056#issuecomment-2093437744): >/cherry-pick release-0.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 2 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit a806361e9ce4a6f229f451619f9227dd069c2d45
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/66351b2a1db8b00009242386
Deploy Preview https://deploy-preview-2056--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

EmilienM commented 2 months ago

/lgtm

huxcrux commented 2 months ago

/lgtm

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [lentzi90] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-infra-cherrypick-robot commented 2 months ago

@mdbooth: new pull request created: #2059

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2056#issuecomment-2093437744): >/cherry-pick release-0.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mdbooth commented 1 month ago

/cherry-pick release-0.9

k8s-infra-cherrypick-robot commented 1 month ago

@mdbooth: new pull request created: #2094

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2056#issuecomment-2119951578): >/cherry-pick release-0.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.