search

kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
275 stars 253 forks source link

🐛 Fix panic executing manager without valid kube context #2057

Closed mdbooth closed 2 months ago

mdbooth commented 2 months ago

Fixes #2054

/hold

netlify[bot] commented 2 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 568cee9e5a28933dc75e8badcf1a71304b7fad71
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/663521f2884dfb0008d96d10
Deploy Preview https://deploy-preview-2057--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

EmilienM commented 2 months ago

/lgtm

EmilienM commented 2 months ago

/hold cancel

jichenjc commented 2 months ago

/approve

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [jichenjc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kashifest commented 2 months ago

How about cherry-pick to release branch ?

EmilienM commented 2 months ago

/cherry-pick release-0.10

k8s-infra-cherrypick-robot commented 2 months ago

@EmilienM: new pull request created: #2061

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2057#issuecomment-2096142130): >/cherry-pick release-0.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.