kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
275 stars 253 forks source link

🌱 Drop dulek from reviewers #2082

Closed dulek closed 1 month ago

dulek commented 1 month ago

What this PR does / why we need it: Going forward I won't be able to contribute time to both CPO and CAPO, so this commit drops me from CAPO reviewers list.

linux-foundation-easycla[bot] commented 1 month ago

CLA Signed

The committers listed above are authorized under a signed CLA.

netlify[bot] commented 1 month ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit 75c5bd2048ec0cc1986c05c987c4125d3cbc55b5
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/66447cef6709a7000766c3b4
Deploy Preview https://deploy-preview-2082--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdbooth commented 1 month ago

Sad to lose you 😞

/approve /lgtm

/cherry-pick release-0.10 /cherry-pick release-0.9

k8s-infra-cherrypick-robot commented 1 month ago

@mdbooth: once the present PR merges, I will cherry-pick it on top of release-0.10 in a new PR and assign it to you.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2082#issuecomment-2112159404): >Sad to lose you 😞 > >/approve >/lgtm > >/cherry-pick release-0.10 >/cherry-pick release-0.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-infra-cherrypick-robot commented 1 month ago

@mdbooth: new pull request created: #2083

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2082#issuecomment-2112159404): >Sad to lose you 😞 > >/approve >/lgtm > >/cherry-pick release-0.10 >/cherry-pick release-0.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 1 month ago

@mdbooth: #2082 failed to apply on top of branch "release-0.9":

Applying: Drop dulek from reviewers
Using index info to reconstruct a base tree...
M   OWNERS_ALIASES
Falling back to patching base and 3-way merge...
Auto-merging OWNERS_ALIASES
CONFLICT (content): Merge conflict in OWNERS_ALIASES
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Drop dulek from reviewers
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2082#issuecomment-2112159404): >Sad to lose you 😞 > >/approve >/lgtm > >/cherry-pick release-0.10 >/cherry-pick release-0.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jichenjc commented 1 month ago

thanks for the contribution @dulek and sorry to lose you here ..