kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
275 stars 253 forks source link

🌱 Add script for API diff check #2096

Closed EmilienM closed 1 month ago

EmilienM commented 1 month ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1860

netlify[bot] commented 1 month ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit e5a460e811978ab06eb296d41af471bb27f6c58d
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/664e1a47350aff000821c458
Deploy Preview https://deploy-preview-2096--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

EmilienM commented 1 month ago

/cc mdbooth

EmilienM commented 1 month ago

mhh I need to find a way to skip it for v1alpha1 stuffs.

EmilienM commented 1 month ago

We agreed the following:

mdbooth commented 1 month ago

/approve

Wouldn't it be nice if we had a tool like Zuul which could test both this PR and https://github.com/kubernetes/test-infra/pull/32644 together?

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jichenjc commented 1 month ago

/lgtm