:book: Fix rootVolume new fields name

Krast76 commented 4 months ago

What this PR does / why we need it:

Since v1beta1 fields for rootVolume got renamed :

From :

 kubectl explain --api-version=infrastructure.cluster.x-k8s.io/v1alpha7 openstackmachinetemplate.spec.template.spec.rootVolume
GROUP:      infrastructure.cluster.x-k8s.io
KIND:       OpenStackMachineTemplate
VERSION:    v1alpha7

FIELD: rootVolume <Object>

DESCRIPTION:
    The volume metadata to boot from

FIELDS:
  availabilityZone      <string>
    <no description>

  diskSize      <integer>
    <no description>

  volumeType    <string>
    <no description>

To :

 kubectl explain --api-version=infrastructure.cluster.x-k8s.io/v1beta1 openstackmachinetemplate.spec.template.spec.rootVolume --recursive
GROUP:      infrastructure.cluster.x-k8s.io
KIND:       OpenStackMachineTemplate
VERSION:    v1beta1

FIELD: rootVolume <Object>

DESCRIPTION:
    The volume metadata to boot from

FIELDS:
  availabilityZone      <Object>
    from        <string>
    enum: Name, Machine
    name        <string>
  sizeGiB       <integer> -required-
  type  <string>

This PR fix documentation example in the book.

Special notes for your reviewer:

TODOs:

[ ] squashed commits
if necessary:
- [ ] includes documentation
- [ ] adds unit tests

/hold

k8s-ci-robot commented 4 months ago

Hi @Krast76. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

netlify[bot] commented 4 months ago

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
Latest commit	97ec78468478b9732206c85b918179173266b7dd
Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6651d50f366b15000897ae14
Deploy Preview	https://deploy-preview-2100--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

EmilienM commented 4 months ago

/lgtm /ok-to-test /hold cancel

mdbooth commented 4 months ago

/approve

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)~~ [mdbooth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubernetes-sigs / cluster-api-provider-openstack