Bastion SG cleanup v2 - Githubissues

EmilienM commented 3 months ago

From @mdbooth:

My only slight worry here is that we're potentially short-cutting everything else that this reconciliation does for something we're expecting to fail sometimes.

I've tried to think through all the ordering scenarios and I suspect this is ok. However, I wonder if it would have been safer to add this delete step at the bottom of the reconcile immediately before setting BastionSecurityGroup to nil.

_Originally posted by @mdbooth in https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2114#discussion_r1631030728_

EmilienM commented 3 months ago

@mdbooth I'll get back to it at some point /assign EmilienM

k8s-triage-robot commented 3 weeks ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

EmilienM commented 3 weeks ago

/remove-lifecycle stale

kubernetes-sigs / cluster-api-provider-openstack

Bastion SG cleanup v2 #2118